Skip to content

BUGFIX EXTPLESK-8950 Fix case when getAll returns 1 database instead of 0 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
whytea91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BUGFIX EXTPLESK-8950 Fix case when getAll returns 1 database instead of 0 #188

whytea91 wants to merge 1 commit into from
+12 −1

Conversation

@whytea91
Copy link

@whytea91 whytea91 commented Feb 3, 2026 •
edited
Loading

When there are no databases on a domain, the API returns:

<?xml version="1.0" encoding="UTF-8"?>
<packet version="1.6.9.1">
    <database>
        <get-db>
            <result>
                <status>ok</status>
                <filter-id>nodatabase.com</filter-id>
            </result>
        </get-db>
    </database>
</packet>

However, the getAll method returns one object with empty values (because if ($xmlResult) is always true, even when there are no DBs).

@sibprogrammer sibprogrammer self-requested a review February 3, 2026 18:12
sibprogrammer
sibprogrammer requested changes Feb 3, 2026
View reviewed changes
@whytea91 whytea91 force-pushed the bugfix-correctly-fetch-current-databases-number branch from 619c2b3 to 73c3eeb Compare February 4, 2026 14:24
sibprogrammer
sibprogrammer requested changes Feb 4, 2026
View reviewed changes
src/Api/Operator/Database.php
$items = [];
foreach ((array) $response->xpath('//result') as $xmlResult) {
if ($xmlResult) {
if (isset($xmlResult->id) && (int) $xmlResult->id > 0) {
Copy link
Member

@sibprogrammer sibprogrammer Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$xmlResult check was removed w/o a reason. Please also make sure composer lint doesn't emit any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sibprogrammer sibprogrammer sibprogrammer requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whytea91 @sibprogrammer